Re: [PATCH 001/001] PCI: PCI quirk for Asus A8V and A8V Deluxe motherboards

[Måns Rullgård <mru@inprovide.com>]

Andras Mantia <amantia@kde.org> writes:

> Måns Rullgård wrote:
>
>> Hmm, we seem to be using different patches.  Here's what I'm using:
>> 
> Oh, yeah. I used the original one posted here (actually I get from
> some -mm patch collection IIRC, I don't remember from which one).

OK, I just used the simpler (and newer) of the two versions that were
posted, and modified as suggested by someone.  Does my version work on
your machine?

> Anyway, my suggestion remains, that the 
> +       if (dev->subsystem_vendor != PCI_VENDOR_ID_ASUSTEK)
> +               return;
> +       if (dev->device != PCI_DEVICE_ID_VIA_8237)
> +               return;
>
> might be not needed at all as it is not ASUS specific.

Doesn't it depend on the BIOS?  My BIOS lets me choose between
"automatic" and "disabled" for the onboard sound.

> I don't understand the second if, as (from my limited knowledge) it
> seems that
>
> DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_VIA,    PCI_DEVICE_ID_VIA_8237,
> asus_hides_ac97_lpc );
>
> already means the function will be called only for devices with PCI id
> PCI_DEVICE_ID_VIA_8237 .

That struck me too.  

-- 
Måns Rullgård
mru@inprovide.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/