Re: [PATCH] Cpuset: remove unnecessary NULL check

Paul Jackson <[email protected]> writes:

> Eric wrote:
>> Comments that refer to a nebulous hack ...
>
> Well, in this case, it wasn't so nebulous, to me anyway.

Right.  The core problem was there was not enough context to see
what the dependency was from the comment.  Having to read
another comment to understand the comment you are reading
usually breaks after a while.

Now that we have git the problem is less severe because we
can look in the history and see what the comment meant when
it was written but that is still a hassle.

> Patch coming soon.

Thanks.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] Cpuset: remove unnecessary NULL check
    • From: Paul Jackson <[email protected]>
  • Re: [PATCH] Cpuset: remove unnecessary NULL check
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH] Cpuset: remove unnecessary NULL check
    • From: Paul Jackson <[email protected]>

• Prev by Date: Re: [PATCH 001/001] PCI: PCI quirk for Asus A8V and A8V Deluxe motherboards
• Next by Date: Re: [PATCH] Cpuset: remove unnecessary NULL check comment fix
• Previous by thread: Re: [PATCH] Cpuset: remove unnecessary NULL check
• Next by thread: [PATCH] Proc: move proc fs hooks from cpuset.c to proc/fs/base.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]