[PATCH] Fix potential NULL pointer deref in gen_init_cpio

Fix potential NULL pointer deref in gen_init_cpio.c spotted by 
coverity checker.
This fixes coverity bug #86

Signed-off-by: Jesper Juhl <[email protected]>
---

 usr/gen_init_cpio.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletion(-)

--- linux-2.6.16-rc6-mm2-orig/usr/gen_init_cpio.c	2006-01-03 04:21:10.000000000 +0100
+++ linux-2.6.16-rc6-mm2/usr/gen_init_cpio.c	2006-03-18 22:17:18.000000000 +0100
@@ -471,6 +471,7 @@ int main (int argc, char *argv[])
 				"ERROR: incorrect format, could not locate file type line %d: '%s'\n",
 				line_nr, line);
 			ec = -1;
+			break;
 		}
 
 		if ('\n' == *type) {
@@ -506,7 +507,8 @@ int main (int argc, char *argv[])
 				line_nr, line);
 		}
 	}
-	cpio_trailer();
+	if (ec == 0)
+		cpio_trailer();
 
 	exit(ec);
 }



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Prev by Date: Emulex IP over FC support.
• Next by Date: Re: 2.6.16-rc6-mm2
• Previous by thread: [PATCH] Cpuset: alloc_pages_node overrides cpuset constraints
• Next by thread: [PATCH] fix potential return of uninitialized variable in scsi_scan (resend)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]