Mike Galbraith <[email protected]> wrote:
>
> On Fri, 2006-03-17 at 23:33 -0800, Andrew Morton wrote:
> > > +static int expired_starving(runqueue_t *rq)
> >
> > I'll make that inline..
> >
>
> Oops, I understood you to want that uninlined.
>
It has just one callsite. Modern gcc should inline it anyway, but older
versions tend to need help.
> > > +{
> > > + int limit;
> > > +
> > > + /*
> > > + * Arrays were recently switched, all is well.
> > > + */
> > > + if (!rq->expired_timestamp)
> > > + return 0;
> > > +
> > > + limit = STARVATION_LIMIT * rq->nr_running;
> >
> > In the previous iteration you had, effectively,
> >
> > if (!limit)
> > return 0;
> >
> > in here. But it's now gone. Deliberate?
>
> Yes. I see no way for it to be zero. I think that was just a leftover.
>
ok..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
