Re: [PATCH] ieee1394/ohci1394 : CycleTooLong interrupt management

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

Jean-Baptiste MUR wrote:
...
> Kernel version : 2.6.16-rc4

(actually plus an ohci1394 patch from the linux1394 development tree)

...
> +                /* If this event occurs, we try to reactivate the "cycle 
> master" bit. */
> +                reg_write(ohci, OHCI1394_LinkControlSet, 
> OHCI1394_LinkControl_CycleMaster);
...

Three minor nits:

There are tabs replaced by spaces and superfluous line breaks inserted
in your posting. Take care that the mailer does not mangle whitespace.
If you cannot prevent this nor switch the mailer, send the patch as
attachment without recoding (i.e. 7bit encoding, not base64 or the
like).

Take care of a maximum line length of 80 characters. For example:

		/* Try to reactivate the "cycle master" bit. */
		reg_write(ohci, OHCI1394_LinkControlSet,
			  OHCI1394_LinkControl_CycleMaster);

The comment is unnecessary since the actual code is clear enough, at
least IMO.

Anyway, thanks again for identifying this problem.
-- 
Stefan Richter
-=====-=-==- --== =---=
http://arcgraph.de/sr/

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/