[patch 1/1] OSS gus_wave missing return check for request_region()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,
in sound/oss/gus_wave.c, request_region() is called without checking the return
value. Here is a simple patch to fix it.
Patch against 2.6.16-rc6-git8.
Please CC me on replies.
Regards.

Signed-off-by: Laurent Wandrebeck <[email protected]>

--- linux-2.6.16-rc6/sound/oss/gus_wave.c.ori   2006-03-17 11:33:36.000000000 +0100
+++ linux-2.6.16-rc6/sound/oss/gus_wave.c       2006-03-17 11:46:46.000000000 +0100
@@ -2938,7 +2938,11 @@ void __init gus_wave_init(struct address
                        model_num = "3.7";
                        gus_type = 0x37;
                        mixer_type = ICS2101;
-                       request_region(u_MixSelect, 1, "GUS mixer");
+                       if (!request_region(u_MixSelect, 1, "GUS mixer")) {
+                           printk(KERN_ERR "gus_card: unable to reserve region %d for mixer\n",
+                                            u_MixSelect);
+                           return;
+                       }
                }
                else
                {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux