Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register

Hi Mark,

Thanks for the reply.

Mark Maule wrote:

There is another problem that CONFIG_IA64_GENERIC still doesn't
build due to error in SGI SN specific code.
It needs additional fix.

Ok, looking back at some of my original patches, it seems like the
declaration of msi_ops got moved from pci.h to and some forward declarations
in ia64/msi.h were removed.  This patch corrects the build problems.

But,

Greg said:

these are core pci things that no one else should care about.

Andrew said:

a declaration for msi_register(), in drivers/pci/pci.h.

> We don't want to add a duplicated declaration like this.

I think the idea already gets objections.

The reason for putting struct msi_ops in pci.h is so that msi code that
resides outside of drivers/pci can use the declaration without having to
reach down into drivers/pci.

The code in arch/ia64/sn/pci/msi.c looks much like
drivers/pci/msi-apic.c.
Why don't you move them to drivers/pci/msi-sgi-sn.c or something?

Thanks,
--
Jun'ichi Nomura, NEC Solutions (America), Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register
    • From: Mark Maule <[email protected]>

• References:
  • [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register
    • From: "Jun'ichi Nomura" <[email protected]>
  • Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register
    • From: "Jun'ichi Nomura" <[email protected]>
  • Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register
    • From: Greg KH <[email protected]>
  • Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register
    • From: "Jun'ichi Nomura" <[email protected]>
  • Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register
    • From: Mark Maule <[email protected]>

• Prev by Date: Re: [RFC, PATCH 5/24] i386 Vmi code patching
• Next by Date: Re: [PATCH] unshare: Cleanup up the sys_unshare interface before we are committed.
• Previous by thread: Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register
• Next by thread: Re: [PATCH] (-mm) drivers/pci/msi: explicit declaration of msi_register
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]