Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver

["Bryan O'Sullivan" <bos@pathscale.com>]

On Thu, 2006-03-16 at 17:46 +0000, Hugh Dickins wrote:

> > >   It seems one should do
> > > get_page() in .nopage, and then the driver can do dma_free_coherent()
> > > when the vma is released.
> > 
> > If that were the case, I'm unclear on how I would do this.  Add a
> > vmops->close method along with the existing vmops->nopage handler?
> 
> If neither mmap nor nopage allocated something, then vmops->close
> would be the wrong point at which to free it, I think.

I think I've satisfied myself that what we're now doing is fairly sane,
so I think we're OK.  I'm sure I'll be corrected in the next round of
driver submission patches if I'm wrong :-)

	<b

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/