Re: [PATCH] Hamradio: Fix a NULL pointer dereference in net/hamradio/mkiss.c

[Eugene Teo <eugene.teo@eugeneteo.net>]

<quote sender="Eugene Teo">
> Pointer ax is dereferenced before NULL check.
> 
> Coverity bug #817
> 
> Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>

Ignore the previous patch please. Here's a resend.

--
Pointer ax is dereferenced before NULL check.

Coverity bug #817

Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>

--- linux-2.6/drivers/net/hamradio/mkiss.c~	2006-03-15 10:05:35.000000000 +0800
+++ linux-2.6/drivers/net/hamradio/mkiss.c	2006-03-16 15:06:02.000000000 +0800
@@ -845,13 +845,15 @@ static int mkiss_ioctl(struct tty_struct
 	unsigned int cmd, unsigned long arg)
 {
 	struct mkiss *ax = mkiss_get(tty);
-	struct net_device *dev = ax->dev;
+	struct net_device *dev;
 	unsigned int tmp, err;
 
 	/* First make sure we're connected. */
 	if (ax == NULL)
 		return -ENXIO;
 
+	dev = ax->dev;
+	
 	switch (cmd) {
  	case SIOCGIFNAME:
 		err = copy_to_user((void __user *) arg, ax->dev->name,

-- 
1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265  9BB8 5883 6DAA A6D1 2F80
main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); }

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/