Re: [PATCH] fix alloc_large_system_hash roundup

    Kenneth> roundup_pow_of_two uses fls, but fls takes an "int"
    Kenneth> argument.  I think that function is buggy on 64-bit
    Kenneth> arch. Is it an oversight or something?

Huh, looks like you're right.  I never looked inside fls() before.
Yes, roundup_pow_of_two() should probably be fixed, since a naive
person (like me) would look at it and think it works on longs.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • RE: [PATCH] fix alloc_large_system_hash roundup
    • From: "Chen, Kenneth W" <[email protected]>

• Prev by Date: PROBLEM: "irq 7: nobody cared" with 2.6.16-rc6
• Next by Date: [RFC][PATCH] Expanding the size of "start" and "end" field in "struct resource"
• Previous by thread: RE: [PATCH] fix alloc_large_system_hash roundup
• Next by thread: Now Hiring 2000 USD a week!
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]