On Wed, 2006-03-15 at 15:44 +0100, Jiri Benc wrote:
> I got SIGABRT in modpost when building a module really deeply nested in
> a filesystem (path > 100 chars):
>
> > Building modules, stage 2.
> > MODPOST
> > *** glibc detected *** scripts/mod/modpost: realloc(): invalid next size: 0x0809f588 ***
> > [...]
>
> This patch fixes that problem.
>
> Signed-off-by: Jiri Benc <[email protected]>
>
> --- linux-2.6.16-rc6.orig/scripts/mod/modpost.c
> +++ linux-2.6.16-rc6/scripts/mod/modpost.c
> @@ -552,7 +552,7 @@ void __attribute__((format(printf, 2, 3)
>
> va_start(ap, fmt);
> len = vsnprintf(tmp, SZ, fmt, ap);
> - if (buf->size - buf->pos < len + 1) {
> + while (buf->size - buf->pos < len + 1) {
> buf->size += 128;
> buf->p = realloc(buf->p, buf->size);
> }
Silly me. To make it more obvious whatz I really meant was:
---- snip ----
if (buf->size - buf->pos < len + 1) {
while (buf->size - buf->pos < len + 1)
buf->size += 128;
buf->p = realloc(buf->p, buf->size);
}
---- snip ----
Bernd
--
Firmix Software GmbH http://www.firmix.at/
mobil: +43 664 4416156 fax: +43 1 7890849-55
Embedded Linux Development and Services
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
