Re: [Patch 1/9] timestamp diff

>
> > +static inline void timespec_diff(struct timespec *start, struct timespec *end,
> > +                              struct timespec *ret)
> > +{
> > +     ret->tv_sec = end->tv_sec - start->tv_sec;
> > +     ret->tv_nsec = end->tv_nsec - start->tv_nsec;
> > +}
> >  #endif /* __KERNEL__ */
>
> I'd suggest normalizing the timespec; better to do it in such a function
> than in all callers of it..
>

Yep, that also looks semantically correct. We will do so.

Thanks,
Balbir
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [Patch 0/9] Per-task delay accounting
    • From: Shailabh Nagar <[email protected]>
  • [Patch 1/9] timestamp diff
    • From: Shailabh Nagar <[email protected]>
  • Re: [Patch 1/9] timestamp diff
    • From: Arjan van de Ven <[email protected]>

• Prev by Date: Re: [Patch 3/9] Block I/O accounting initialization
• Next by Date: NFS superblock sharing implies mount flags bug
• Previous by thread: Re: [Patch 1/9] timestamp diff
• Next by thread: Patch 2/9] Initialization
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]