Shaohua Li <[email protected]> wrote:
>
> On Wed, 2006-03-15 at 13:44 +0800, Nathan Lynch wrote:
> > Ashok Raj wrote:
> > > On Mon, Mar 13, 2006 at 02:22:23PM -0800, Andrew Morton wrote:
> > > >
> > > > And does it affect pretend-x86-hotplug, or is it only affecting
> > real hotplug?
> > > >
> > > its no more pretend-x86, in the past we used to put the cpu in
> > idle(),
> > > now we do put the cpu in halt and bring back by another startup ipi,
> > just like
> > > boot sequence, both for x86 and x86_64.
> >
> > That's actually broken since 2.6.14 (at least on my P3 box); please
> > see:
> >
> > Subject: i386 cpu hotplug bug - instant reboot when onlining secondary
> >
> > http://lkml.org/lkml/2006/2/19/186
> Works for me. But I saw a warning.
Guys, will you please stop being so cryptic? What worked for you? What
warning? wtf is going on? Who owns this problem, whatever it is?
<head spins>
> linux-2.6.15-root/arch/i386/kernel/cpu/common.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN arch/i386/kernel/cpu/common.c~cpuhp arch/i386/kernel/cpu/common.c
> --- linux-2.6.15/arch/i386/kernel/cpu/common.c~cpuhp 2006-03-14 12:13:43.000000000 +0800
> +++ linux-2.6.15-root/arch/i386/kernel/cpu/common.c 2006-03-14 12:14:12.000000000 +0800
> @@ -605,7 +605,7 @@ void __devinit cpu_init(void)
> /* alloc_bootmem_pages panics on failure, so no check */
> memset(gdt, 0, PAGE_SIZE);
> } else {
> - gdt = (struct desc_struct *)get_zeroed_page(GFP_KERNEL);
> + gdt = (struct desc_struct *)get_zeroed_page(GFP_ATOMIC);
That would be rather a sad thing to have to do. OK if it's during initial
bootup, less OK if it's during CPU hot-add.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
