Re: [PATCH][3/4] sched: add above background load function

Peter Williams writes:

Con Kolivas wrote:

+		if (weighted_cpuload(cpu) >= SCHED_LOAD_SCALE)
+			return 1;

I think that you may need to take into account the contribution to the load by your swap prefetching thread when it calls this function otherwise it could cause an incorrect (from your point of view) positive return value. If the thread has a positive nice value this comment can probably be ignored.

kprefetchd runs at nice 19.

Cheers,
Con

Attachment: pgpCVIZK00Yn6.pgp
Description: PGP signature

---

• References:
  • [PATCH][3/4] sched: add above background load function
    • From: Con Kolivas <[email protected]>
  • Re: [PATCH][3/4] sched: add above background load function
    • From: Peter Williams <[email protected]>

• Prev by Date: Re: A lockless pagecache for Linux
• Next by Date: Re: [PATCH 2.6.16-rc6] Promise SuperTrak driver
• Previous by thread: Re: [PATCH][3/4] sched: add above background load function
• Next by thread: [PATCH][4/4] mm: Implement swap prefetching tweaks
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]