Re: [PATCH] crypto: fix key alignment in tcrypt

[Herbert Xu <herbert@gondor.apana.org.au>]

On Sat, Mar 11, 2006 at 05:48:41PM -0600, Matt Mackall wrote:
>
> > > Wouldn't it be better to simply move this to the head of the structure?
> > 
> > That wouldn't help, since the whole structure will still be only 8-bit
> > aligned.
> 
> Ahh, hadn't noticed the struct was entirely populated by chars.

Actually moving it to the head is good anyway because we may reduce the
amount of padding between vectors.  On i386 however it is size-neutral
with respect to the vectors.  However, it did save 45 bytes on the code
front.

I've applied the patch with the structure rearrangement so that the large
power-of-2 sized members come first.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/