Re: [RFC: 2.6 patch] hostap_hw.c:hfa384x_set_rid(): fix error handling

On Fri, Mar 10, 2006 at 12:06:46AM +0100, Adrian Bunk wrote:

> The Coverity checker noted that the call to prism2_hw_reset() was dead 
> code.
> 
> Does this patch change the code to what was intended?

Thanks! Based on my CVS history, it looks like this was broken in 2002
when the access command was moved from another function and verification
of -ETIMEDOUT value was not moved correctly. The original behavior would
be achieved by changing your patch to call printk first before the moved
prism2_hw_reset(dev) call. I added this (with the re-ordered printk) to
my queue for wireless-2.6.

-- 
Jouni Malinen                                            PGP id EFC895FA
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [RFC: 2.6 patch] hostap_hw.c:hfa384x_set_rid(): fix error handling
  - From: Adrian Bunk <[email protected]>

Prev by Date: Re: [RFC][PATCH] USB touch screen driver, all-in-one
Next by Date: Re: [2.6 patch] hostap_ap.c:hostap_add_sta(): inconsequent NULL checking
Previous by thread: [RFC: 2.6 patch] hostap_hw.c:hfa384x_set_rid(): fix error handling
Next by thread: [RFC: 2.6 patch] chelsio/espi.c:tricn_init(): remove dead code
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]