Re: [PATCH] KERN_SETUID_DUMPABLE in /proc/sys/fs/

[ebiederm@xmission.com (Eric W. Biederman)]

Arjan van de Ven <arjan@infradead.org> writes:

>
> diff -purN linux-2.6.16-rc5/include/linux/sysctl.h
> linux-2.6.16-rc5-setuid/include/linux/sysctl.h
> --- linux-2.6.16-rc5/include/linux/sysctl.h 2006-02-27 09:13:31.000000000 +0100
> +++ linux-2.6.16-rc5-setuid/include/linux/sysctl.h 2006-03-11 09:02:13.000000000
> +0100
> @@ -144,7 +144,6 @@ enum
>  	KERN_UNKNOWN_NMI_PANIC=66, /* int: unknown nmi panic flag */
>  	KERN_BOOTLOADER_TYPE=67, /* int: boot loader type */
>  	KERN_RANDOMIZE=68, /* int: randomize virtual address space */
> -	KERN_SETUID_DUMPABLE=69, /* int: behaviour of dumps for setuid core */
>  	KERN_SPIN_RETRY=70,	/* int: number of spinlock retries */
>  	KERN_ACPI_VIDEO_FLAGS=71, /* int: flags for setting up video after ACPI
> sleep */
>  };
> @@ -759,6 +758,9 @@ enum
>  	FS_AIO_NR=18,	/* current system-wide number of aio requests */
>  	FS_AIO_MAX_NR=19, /* system-wide maximum number of aio requests */
>  	FS_INOTIFY=20,	/* inotify submenu */
> + /* Note: the following got misplaced but this mistake is
> +			   now part of the ABI */
> +	FS_SETUID_DUMPABLE=21, /* int: behaviour of dumps for setuid core */
This must be number 69 here.  Or else we break the sys_sysctl ABI.
>  };
>  

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/