Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside

On Fri, Mar 10, 2006 at 11:08:29AM +0300, Kirill Korotaev wrote:
> +	page = find_or_create_page(mapping, 0,
> +			mapping_gfp_mask(mapping) | gfp_mask);

> +int page_symlink(struct inode *inode, const char *symname, int len)
> +{
> +	return __page_symlink(inode, symname, len, GFP_KERNEL);

s/GFP_KERNEL/0/; if somebody has e.g. GFP_NOFS in their mapping flags,
you end up breaking their code.  We really pass extra flags to be added
to default ones; page_symlink() should pass 0.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside
    • From: Kirill Korotaev <[email protected]>

• References:
  • [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside
    • From: Kirill Korotaev <[email protected]>

• Prev by Date: Re: [RFC PATCH] ext3 writepage() journal avoidance
• Next by Date: Re: [PATCH 0/4] PCI legacy I/O port free driver (take4)
• Previous by thread: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside
• Next by thread: Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]