Re: [PATCH] AHCI prefetch

[Tejun Heo <htejun@gmail.com>]

On Sat, Mar 04, 2006 at 12:35:05PM -0500, Jeff Garzik wrote:
> 
> This patch has been sitting in my tmp directory for ages.
> 
> We should probably turn this on, though the practical difference is
> probably minimal.
> 

The patch works okay on my machine (ICH7R) although the patch didn't
apply to #upstream.  I'm not very sure about this change though.

1. Why apply it only to ATAPI devices?  ATA devices can benefit to.
   If it's because this bit shouldn't be turned on for NCQ, we can
   turn it on conditionally.  We'll probably need similar condition
   for ATAPI devices too if we support FIS-based PM switching.

2. I'm a bit skeptical whether this change will bring any noticeable
   performance improvement.  OTOH, this seems to be a good source for
   obscure problems on some controllers which might not implement/test
   this feature properly.  As more controllers implement AHCI spec,
   the possibility grows.

Anyways, here's the patch regenerated against #upstream.

diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c
index 1c2ab3d..cfa6eaf 100644
--- a/drivers/scsi/ahci.c
+++ b/drivers/scsi/ahci.c
@@ -66,6 +66,7 @@ enum {
 	AHCI_IRQ_ON_SG		= (1 << 31),
 	AHCI_CMD_ATAPI		= (1 << 5),
 	AHCI_CMD_WRITE		= (1 << 6),
+	AHCI_CMD_PREFETCH	= (1 << 7),
 	AHCI_CMD_RESET		= (1 << 8),
 	AHCI_CMD_CLR_BUSY	= (1 << 10),
 
@@ -631,7 +632,7 @@ static void ahci_qc_prep(struct ata_queu
 	if (qc->tf.flags & ATA_TFLAG_WRITE)
 		opts |= AHCI_CMD_WRITE;
 	if (is_atapi)
-		opts |= AHCI_CMD_ATAPI;
+		opts |= AHCI_CMD_ATAPI | AHCI_CMD_PREFETCH;
 
 	ahci_fill_cmd_slot(pp, opts);
 }
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/