Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver

 > +		yield();	/* don't hog the cpu */

You probably don't want to do this -- yield() means "put me at the
tail of the runqueue."  I think cond_resched() is more likely what you
want.

 > +#endif
 > +/* END_NOSHIP_TO_OPENIB */

uhh... and I don't see an #if to match that #endif.

 - R.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
    • From: "Bryan O'Sullivan" <[email protected]>

• Prev by Date: [PATCH 1/1] x86: Make _syscallX() macros compile in PIC mode on i386
• Next by Date: Re: ext3_ordered_writepage() questions
• Previous by thread: Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
• Next by thread: Re: [PATCH 10 of 20] ipath - support for userspace apps using core driver
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]