[PATCH] Write the inode itself in block_fsync()

Hi,

For block device's inode, we don't write a inode's meta data
itself. But, I think we should write inode's meta data for fsync().

Signed-off-by: OGAWA Hirofumi <[email protected]>
---

 fs/block_dev.c |   16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff -puN fs/block_dev.c~block_fsync-write-inode fs/block_dev.c
--- linux-2.6/fs/block_dev.c~block_fsync-write-inode	2006-03-05 21:51:15.000000000 +0900
+++ linux-2.6-hirofumi/fs/block_dev.c	2006-03-05 22:28:28.000000000 +0900
@@ -19,6 +19,7 @@
 #include <linux/module.h>
 #include <linux/blkpg.h>
 #include <linux/buffer_head.h>
+#include <linux/writeback.h>
 #include <linux/mpage.h>
 #include <linux/mount.h>
 #include <linux/uio.h>
@@ -232,7 +233,20 @@ static loff_t block_llseek(struct file *
  
 static int block_fsync(struct file *filp, struct dentry *dentry, int datasync)
 {
-	return sync_blockdev(I_BDEV(filp->f_mapping->host));
+	struct inode *inode = dentry->d_inode;
+	int ret = 0, err;
+
+	if (!datasync || (inode->i_state & I_DIRTY_DATASYNC)) {
+		struct writeback_control wbc = {
+			.sync_mode = WB_SYNC_ALL,
+			.nr_to_write = 0,	/* sys_fsync did this */
+		};
+		ret = sync_inode(inode, &wbc);
+	}
+	err = sync_blockdev(I_BDEV(filp->f_mapping->host));
+	if (!ret)
+		ret = err;
+	return err;
 }
 
 /*
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Write the inode itself in block_fsync()
    • From: Sam Vilain <[email protected]>

• Prev by Date: [PATCH] Move cond_resched() after iput() in sync_sb_inodes()
• Next by Date: [PATCH] Fix a race condition between ->i_mapping and iput()
• Previous by thread: [PATCH] Move cond_resched() after iput() in sync_sb_inodes()
• Next by thread: Re: [PATCH] Write the inode itself in block_fsync()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]