Re: [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (updated patch)

Thanks! I'll send the corrected patch.
So, everythings fine now?

looks so! Will be glad to Ack/Sign or whatever needed :)))

	d_free(dentry);
	if (parent != dentry)
		dput(parent);
	spin_lock(&dcache_lock);
+	sb->s_prunes--;
+	if (likely(!sb->s_prunes))

<<< Is it possibe to do something like:
if (unlikely(!sb->s_root && !sb->s_prunes))
?

Uh, I forgot about that one. You already complained about that before :(

But I'm not sure it is that simple... s_root is set to NULL w/o locks, so I wonder whether it is safe to check it here or we can miss some wakeups...

Thanks,
Kirill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (updated patch)
    • From: Jan Blunck <[email protected]>

• References:
  • [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (updated patch)
    • From: Jan Blunck <[email protected]>
  • Re: [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (updated patch)
    • From: Kirill Korotaev <[email protected]>
  • Re: [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (updated patch)
    • From: Jan Blunck <[email protected]>

• Prev by Date: Re: 2.6.16-rc5-mm3 -- BUG: sleeping function called from invalid context at include/linux/rwsem.h:43 in_atomic():0, irqs_disabled():1
• Next by Date: ext3_ordered_writepage() questions
• Previous by thread: Re: [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (updated patch)
• Next by thread: Re: [PATCH] Fix shrink_dcache_parent() against shrink_dcache_memory() race (updated patch)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]