Re: [PATCH] fix kexec asm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Út 07-03-06 21:16:34, Eric W. Biederman wrote:
> Chris Mason <[email protected]> writes:
> 
> > From: Michael Matz <[email protected]>
> >
> > While testing kexec and kdump we hit problems where the new kernel would
> > freeze or instantly reboot.  The easiest way to trigger it was to kexec a
> > kernel compiled for CONFIG_M586 on an athlon cpu.  Compiling
> > for CONFIG_MK7 instead would work fine.
> >
> > The patch below fixes a few problems with the kexec inline asm.
> 
> Thanks.  Specifying the stomp of %eax in load_segments is definitely
> good.  The memory stomp looks excessive and if this was a fast path
> I would worry about it.  As it is better safe than sorry.

Why excessive? It reloads %ss, AFAICS; at that point, all the stack
potentially changes from gcc's POV.
								Pavel
-- 
Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux