On Wed, Mar 08, Balbir Singh wrote: > > wait_on_prunes() breaks out if sb->prunes == 0. What if shrink_dcache_parent() > now calls select_parent(). select_parent() could still find entries > with d_count > 0 and skip them and shrink_dcache_memory() can still cause > the race condition to occur. > > I think pushing wait_on_prunes() to after shrink_dcache_parent() will > most likely solve the race. > This is why I used to let shrink_dache_parent() only return after an unsuccessfull select_parent() after a wait. Regards, Jan -- Jan Blunck [email protected] SuSE LINUX AG - A Novell company Maxfeldstr. 5 +49-911-74053-608 D-90409 Nürnberg http://www.suse.de - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- References:
- Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
- From: Neil Brown <[email protected]>
- Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
- From: Neil Brown <[email protected]>
- Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
- From: "Balbir Singh" <[email protected]>
- Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
- From: Neil Brown <[email protected]>
- Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
- From: Kirill Korotaev <[email protected]>
- Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
- From: Neil Brown <[email protected]>
- Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
- From: Balbir Singh <[email protected]>
- Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
- From: Neil Brown <[email protected]>
- Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
- From: Balbir Singh <[email protected]>
- Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
- Prev by Date: Re: [SUSPEND] Screen slides down after STR / neomagic
- Next by Date: Re: [future of drivers?] a proposal for binary drivers.
- Previous by thread: Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
- Next by thread: Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
- Index(es):
 |