Re: [patch 2/4] net: percpufy frequently used vars -- struct proto.memory_allocated

Ravikiran G Thirumalai <[email protected]> wrote:
>
> -	if (atomic_read(sk->sk_prot->memory_allocated) < sk->sk_prot->sysctl_mem[0]) {
>  +	if (percpu_counter_read(sk->sk_prot->memory_allocated) <
>  +			sk->sk_prot->sysctl_mem[0]) {

Bear in mind that percpu_counter_read[_positive] can be inaccurate on large
CPU counts.

It might be worth running percpu_counter_sum() to get the exact count if we
think we're about to cause something to fail.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 2/4] net: percpufy frequently used vars -- struct proto.memory_allocated
    • From: Ravikiran G Thirumalai <[email protected]>

• References:
  • [patch 0/4] net: percpufy frequently used vars on struct proto
    • From: Ravikiran G Thirumalai <[email protected]>
  • [patch 2/4] net: percpufy frequently used vars -- struct proto.memory_allocated
    • From: Ravikiran G Thirumalai <[email protected]>

• Prev by Date: Re: [patch 1/4] net: percpufy frequently used vars -- add percpu_counter_mod_bh
• Next by Date: Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
• Previous by thread: [patch 2/4] net: percpufy frequently used vars -- struct proto.memory_allocated
• Next by thread: Re: [patch 2/4] net: percpufy frequently used vars -- struct proto.memory_allocated
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]