Re: fix usbmixer double kfree.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Mon, 6 Mar 2006 16:41:11 -0800,
Andrew Morton wrote:
> 
> Dave Jones <[email protected]> wrote:
> >
> > snd_ctl_add() kfree's the kcontrol already if we fail there,
> > so this driver is currently doing a double kfree.
> 
> Well sometimes it does.  If we hit one of those snd_assert() abominations,
> snd_ctl_add() will return error without freeing the kcontrol.

Indeed.  I'll fix them later.

> Still, a leak is better than a double-free.

Yep :)


thanks,

Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux