On Mon, 6 Mar 2006, Phillip Susi wrote:
> > > inode->i_uid = le32_to_cpu(fe->uid);
> > > - if ( inode->i_uid == -1 ) inode->i_uid =
> > > UDF_SB(inode->i_sb)->s_uid;
> > > + if ( inode->i_uid == -1 || UDF_QUERY_FLAG(inode->i_sb,
> > > UDF_FLAG_UID_IGNORE) )
> > > + inode->i_uid = UDF_SB(inode->i_sb)->s_uid;
> >
> > Formatting.
>
> What exactly do you mean by formatting?
Looks like you're using two spaces. Indentation is one tab and one tab is
exactly eight characters (see Documentation/CodingStyle).
On Mon, 6 Mar 2006, Phillip Susi wrote:
> Yes, if you chown a file that is owned by -1 on disk, you do want it to be
> saved back with the new id, unless you set the forget option.
Okay, fair enough. I see akpm has taken your patch. Please make sure the
mount options are documented. Thanks!
(Please note that we didn't fix the unconditional memset now, so there's
dead code in udf_update_inode(). The check for TAG_IDENT_USE will always
fail.)
Pekka
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
