Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super

+               /* avoid further wakeups */
+               sb->s_pending_iputs = 65000;

This looks a bit ugly, what is 65000?

Just the first big number that came to by head... probably not needed.

ok, I would rather use a const or a #define and hide it under a
meaningful name, with comments. If it is not needed, then nothing like
avoiding magic numbers.

It looks like this assignment is not needed at all if "wait_for_prunes" is moved after dput(root), since no more dentries should exist after that point and wakeup can not potentially happen.

Thanks,
Kirill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Neil Brown <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Neil Brown <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: "Balbir Singh" <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: Neil Brown <[email protected]>
  • Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
    • From: "Balbir Singh" <[email protected]>

• Prev by Date: Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
• Next by Date: Re: VFS nr_files accounting
• Previous by thread: Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
• Next by thread: Re: [PATCH] Busy inodes after unmount, be more verbose in generic_shutdown_super
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]