Re: [PATCH 1/8] [I/OAT] DMA memcpy subsystem

On 3/3/06, David S. Miller <[email protected]> wrote:
> > +static spinlock_t dma_list_lock;
>
> Please use DEFINE_SPINLOCK().
>
> > +static void dma_chan_free_rcu(struct rcu_head *rcu) {
>
> Newline before the brace please.
>
> > +static void dma_async_device_cleanup(struct kref *kref) {
>
> Newline before the brace please.
>
> > +struct dma_chan_percpu
> > +{
>
> Left brace on the same line as "struct dma_chan_percpu" please.
>
> > +struct dma_chan
> > +{
>
> Similarly.
>
> Otherwise this patch looks mostly ok.

Thanks Dave,

I'll apply these and other feedback and get updated patches generated.

- Chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH 0/8] Intel I/O Acceleration Technology (I/OAT)
  - From: Chris Leech <[email protected]>
- [PATCH 1/8] [I/OAT] DMA memcpy subsystem
  - From: Chris Leech <[email protected]>
- Re: [PATCH 1/8] [I/OAT] DMA memcpy subsystem
  - From: "David S. Miller" <[email protected]>

Prev by Date: [git patches] net driver fixes
Next by Date: Re: RFC: move SDP from AF_INET_SDP to IPPROTO_SDP
Previous by thread: Re: [PATCH 1/8] [I/OAT] DMA memcpy subsystem
Next by thread: Re: [PATCH 1/8] [I/OAT] DMA memcpy subsystem
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]