On Mon, Mar 06 2006, Jens Axboe wrote:
> On Mon, Mar 06 2006, Andrew Morton wrote:
> > Jens Axboe <[email protected]> wrote:
> > >
> > > ...
> > > >
> > > > If you expand the two above statements you get:
> > > >
> > > > spin_lock_irqsave(q->queue_lock, flags);
> > > > __elv_add_request(q, rq, where, plug);
> > > > spin_unlock_irqrestore(q->queue_lock, flags);
> > > > spin_lock_irq(q->queue_lock);
> > > > __generic_unplug_device(q);
> > > > spin_unlock_irq(q->queue_lock);
> > > >
> > > > which is a bit sad.
> > >
> > > Indeed, I'll do the locking manually and use the __ functions.
> >
> > blk_execute_rq_nowait() and pkt_generic_packet() also do the above two
> > calls. It might be worth creating a new library function.
>
> Yes it might, there are other call sites like this in the kernel. But
> it's basically blk_execute_rq_nowait(). I'll make that change.
First step:
http://brick.kernel.dk/git/?p=linux-2.6-block.git;a=commitdiff;h=6a09cbe527fe051c919c5d9526ba4a2d2689fb61
Second step:
http://brick.kernel.dk/git/?p=linux-2.6-block.git;a=commitdiff;h=0f62c8deddf27b15f56edcf6414c3905e93fd0ef
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
