Zwane Mwaikambo <[email protected]> wrote:
>
> On Thu, 2 Mar 2006, Edgar Hucek wrote:
>
> > This patch makes the kernel bootable again on ia32 EFI systems.
> >
> > Signed-off-by: Edgar Hucek <[email protected]>
> >
>
> spin_lock(&efi_rt_lock);
> local_irq_save(efi_rt_eflags);
>
> That looks like a race, not to mention that efi_rt_eflags is a global
> variable. The same strange ordering occurs on unlock, i presume this code
> 'works' because it's done early during boot?
No, the code's OK. This is the prologue function. The epilogue function
does the opposite. In between, this CPU will dink around with EFI stuff.
And the order is correct too - the lock protects efi_rt_eflags.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
