Re: 2.6.16-rc5: known regressions [600X S3 sleep]

[Sanjoy Mahajan <sanjoy@mrao.cam.ac.uk>]

>>>> Subject    : S3 sleep hangs the second time - 600X
>>>> References : http://bugzilla.kernel.org/show_bug.cgi?id=5989

>>From: "Yu, Luming" <luming.yu@intel.com>
>>> According to bug report, the BIOS DSDT is modified.  I don't know
>>> how these changes affect the results of suspend/resume. But, it is
>>> clear this is NOT right approach to fix problem. Hence, I need the
>>> testing report with un-modified DSDT on TP 600X, bios 1.11.

>>I'll try it, although I don't think I'll get any data on the problem.
>>The unmodified DSDT (bios 1.11) lacks an S3 sleep object, so I had to
>>modify the DSDT even to get S3 to sleep at all.  See
>><http://bugzilla.kernel.org/show_bug.cgi?id=3534> for that discussion.

I just tried the first failing commit
(02b28a33aae93a3b53068e0858d62f8bcaef60a3):

Author: Len Brown <len.brown@intel.com>
Date:   Mon Dec 5 16:46:36 2005 -0500

    [ACPI] Enable Embedded Controller (EC) interrupt mode by default
    
    "ec_intr=0" reverts to polling
    "ec_burst=" no longer exists.
    
    Signed-off-by: Len Brown <len.brown@intel.com>
    Acked-by: Luming Yu <luming.yu@intel.com>

but with the vanilla (BIOS 1.11) DSDT.  And not only did S3 sleep
happen, but the thermal+processor bug didn't show up: i.e. it did two
(actually) many S3 sleep-wake cycles.  So the problem is due to
something in the modified DSDT, which is either a problem itself or it
exposes another problem.

[Picture of me hanging head in shame for putting people to the trouble.]

My only excuse is that long ago (2.6.11), the machine wouldn't S3
sleep at all with the vanilla DSDT, and I patched it as recommended by
the ACPI experts.  However, the current ACPI interpreter seems to
handle the 600X's mangy DSDT.

Now I agree 100% with Len Brown that it's best to have ACPI handle
marginal DSDT's, not hack the DSDT.

-Sanjoy

`Never underestimate the evil of which men of power are capable.'
         --Bertrand Russell, _War Crimes in Vietnam_, chapter 1.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/