[PATCH] fix potential jiffies overflow

I found i386 timer_resume is updating jiffies, not jiffies_64.  It
looks there is a potential overflow problem.  Is this a correct fix?

Signed-off-by: Atsushi Nemoto <[email protected]>

diff --git a/arch/i386/kernel/time.c b/arch/i386/kernel/time.c
index a14d594..e4ed172 100644
--- a/arch/i386/kernel/time.c
+++ b/arch/i386/kernel/time.c
@@ -413,7 +413,7 @@ static int timer_resume(struct sys_devic
 	xtime.tv_sec = sec;
 	xtime.tv_nsec = 0;
 	write_sequnlock_irqrestore(&xtime_lock, flags);
-	jiffies += sleep_length;
+	jiffies_64 += sleep_length;
 	wall_jiffies += sleep_length;
 	if (last_timer->resume)
 		last_timer->resume();
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] fix potential jiffies overflow
    • From: "Ram Gupta" <[email protected]>

• Prev by Date: Re: My desperation: Oops during mkfs.ext3 on large partitions
• Next by Date: [PATCH 1/4] PCI legacy I/O port free driver (take4) - Add no_ioport flag into pci_dev
• Previous by thread: [PATCH] simplify update_times (avoid jiffies/jiffies_64 aliasing problem)
• Next by thread: Re: [PATCH] fix potential jiffies overflow
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]