Re: [PATCH] move eeh_add_device_tree_late()

On Wed, Mar 01, 2006 at 10:35:55AM -0600, John Rose wrote:
> Good catch, Mark.
Heh, thanks.

> Commit 827c1a6c1a5dcb2902fecfb648f9af6a532934eb introduced a new
> function that calls eeh_add_device_late() implicitly.  This patch
> reorders the two functions in question to fix the compile error.  This
> might be preferable to exposing eeh_add_device_late() in eeh.h.
Hmm, you still left the EXPORT_SYMBOL(eeh_add_device_late) and you didn't
make eeh_add_device_late() static. Shouldn't you do that if you don't want
to make it accessible outside of eeh.c?
	--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
[email protected]
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- [PATCH] move eeh_add_device_tree_late()
  - From: John Rose <[email protected]>

References:
- [PATCH] powerpc: restore eeh_add_device_late() prototype
  - From: Mark Fasheh <[email protected]>
- Re: [PATCH] powerpc: restore eeh_add_device_late() prototype
  - From: Mark Fasheh <[email protected]>
- [PATCH] move eeh_add_device_tree_late()
  - From: John Rose <[email protected]>

Prev by Date: Re: [2.6 patch] make UNIX a bool
Next by Date: Re: AMD64 X2 lost ticks on PM timer
Previous by thread: [PATCH] move eeh_add_device_tree_late()
Next by thread: [PATCH] move eeh_add_device_tree_late()
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]