Re: 2.6.16-rc5-mm1

["J.A. Magallon" <jamagallon@able.es>]

On Wed, 1 Mar 2006 02:32:35 -0800, Andrew Morton <akpm@osdl.org> wrote:

> 
> Useful, thanks.  So the second batch of /proc patches are indeed the problem.
> 
> If you have (even more) time you could test
> http://www.zip.com.au/~akpm/linux/patches/stuff/2.6.16-rc5-mm2-pre1.gz. 
> That's the latest of everything with the problematic sysfs patches reverted
> and Eric's recent /proc fixes.
> 

I just tried rc5-mm1 and this. With this I can run java apps/applets again
without locking my system. 

I also applied the patch you posted for inotify, but now I get this new one:

Mar  1 15:11:04 werewolf kernel: [ 1424.891482] BUG: warning at fs/inotify.c:410/set_dentry_child_flags()
Mar  1 15:11:04 werewolf kernel: [ 1424.891494]  <b0177dae> set_dentry_child_flags+0x10b/0x113   <b0178109> remove_watch_no_event+0x138/0x171
Mar  1 15:11:04 werewolf kernel: [ 1424.891545]  <b0178195> inotify_release+0x53/0x193   <b01556fa> __fput+0x91/0x181
Mar  1 15:11:04 werewolf kernel: [ 1424.891578]  <b0152e37> filp_close+0x3e/0x62   <b0146011> exit_mmap+0xc5/0x116
Mar  1 15:11:04 werewolf kernel: [ 1424.891619]  <b011b297> put_files_struct+0x8b/0xf8   <b011c2ee> do_exit+0x152/0x8c0
Mar  1 15:11:04 werewolf kernel: [ 1424.891660]  <b011ca85> do_group_exit+0x29/0x72   <b01256dd> get_signal_to_deliver+0x27c/0x42a
Mar  1 15:11:04 werewolf kernel: [ 1424.891686]  <b01025fc> do_notify_resume+0x1a0/0x670   <b02a83d4> unix_sock_destructor+0x7a/0x10a
Mar  1 15:11:04 werewolf kernel: [ 1424.891721]  <b02a6e25> unix_release_sock+0x237/0x26f   <b0158742> invalidate_inode_buffers+0xa/0x53
Mar  1 15:11:04 werewolf kernel: [ 1424.891748]  <b016b01d> destroy_inode+0x28/0x37   <b0130383> sys_futex+0xcc/0x122
Mar  1 15:11:04 werewolf kernel: [ 1424.891781]  <b0102c92> work_notifysig+0x13/0x19  

It looks like there are couple more WARN_ONs spread over inotify.c.
Full patch:

--- devel/fs/inotify.c~a	2006-03-01 02:47:01.000000000 -0800
+++ devel-akpm/fs/inotify.c	2006-03-01 02:47:06.000000000 -0800
@@ -402,12 +402,8 @@
 		list_for_each_entry(child, &alias->d_subdirs, d_u.d_child) {
 			spin_lock(&child->d_lock);
 			if (watched) {
-				WARN_ON(child->d_flags &
-						DCACHE_INOTIFY_PARENT_WATCHED);
 				child->d_flags |= DCACHE_INOTIFY_PARENT_WATCHED;
 			} else {
-				WARN_ON(!(child->d_flags &
-					DCACHE_INOTIFY_PARENT_WATCHED));
 				child->d_flags&=~DCACHE_INOTIFY_PARENT_WATCHED;
 			}
 			spin_unlock(&child->d_lock);
@@ -530,7 +530,6 @@ void inotify_d_instantiate(struct dentry
 	if (!inode)
 		return;
 
-	WARN_ON(entry->d_flags & DCACHE_INOTIFY_PARENT_WATCHED);
 	spin_lock(&entry->d_lock);
 	parent = entry->d_parent;
 	if (inotify_inode_watched(parent->d_inode))

--
J.A. Magallon <jamagallon()able!es>     \               Software is like sex:
werewolf!able!es                         \         It's better when it's free
Mandriva Linux release 2006.1 (Cooker) for i586
Linux 2.6.15-jam14 (gcc 4.0.3 (4.0.3-0.20060215.2mdk for Mandriva Linux release 2006.1))

Attachment: signature.asc
Description: PGP signature