On Sun, Feb 26, 2006 at 04:55:49PM -0700, Matthew Wilcox wrote:
> On Sun, Feb 26, 2006 at 10:16:51PM +0100, Adrian Bunk wrote:
> > he Coverity checker correctly noted, that in function board_replaced in
> > drivers/pci/hotplug/cpqphp_ctrl.c, the variable src always has the
> > value 8, and therefore much code after the
> >
> > ...
> > if (rc || src) {
> > ...
> > if (rc)
> > return rc;
> > else
> > return 1;
> > }
> > ...
> >
> >
> > can never be called.
> >
> > This patch removes the unreachable code in this function fixing kernel
> > Bugzilla #6073.
>
> It seems much more likely to me that the '|| src' indicates a bug, and
> the unreachable code should have been reached. Why not cc the
> maintainer for his opinion?
I did, at least I thought I did...
I thought the following was the right entry in MAINTAINERS for this
driver:
PCI HOTPLUG COMPAQ DRIVER
P: Greg Kroah-Hartman
M: [email protected]
S: Maintained
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
