Re: OOM-killer too aggressive?

[Chris Largret <largret@gmail.com>]

On Sun, 2006-02-26 at 16:20 -0800, Andrew Morton wrote:

> Sigh.  The floppy driver's just a jpke.  Looks like the failed allocation
> fell back to vmalloc then screwed it up.

> You could try this one instead, although I guess I'll need to fire up the
> test box for this bug.

> --- devel/include/asm-x86_64/floppy.h~b	2006-02-26 16:15:44.000000000 -0800
> +++ devel-akpm/include/asm-x86_64/floppy.h	2006-02-26 16:16:21.000000000 -0800
> @@ -40,7 +40,7 @@
>  #define fd_disable_irq()        disable_irq(FLOPPY_IRQ)
>  #define fd_free_irq()		free_irq(FLOPPY_IRQ, NULL)
>  #define fd_get_dma_residue()    SW._get_dma_residue(FLOPPY_DMA)
> -#define fd_dma_mem_alloc(size)	SW._dma_mem_alloc(size)
> +#define fd_dma_mem_alloc(size)	__alloc_pages(GFP_KERNEL|__GFP_DMA32, get_order(size))
>  #define fd_dma_setup(addr, size, mode, io) SW._dma_setup(addr, size, mode, io)
>  
>  #define FLOPPY_CAN_FALLBACK_ON_NODMA

CC      drivers/block/floppy.o
drivers/block/floppy.c: In function `raw_cmd_copyin':
drivers/block/floppy.c:3245: error: too few arguments to function
`__alloc_pages'
drivers/block/floppy.c: In function `floppy_open':
drivers/block/floppy.c:3738: error: too few arguments to function
`__alloc_pages'
drivers/block/floppy.c:3742: error: too few arguments to function
`__alloc_pages'
make[2]: *** [drivers/block/floppy.o] Error 1
make[1]: *** [drivers/block] Error 2
make: *** [drivers] Error 2


I'm sorry, but I'm not sure where to start for looking up the definition
for __alloc_pages().

--
Chris Largret <http://daga.dyndns.org>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/