Re: [PATCH 2/6] relax sig_needs_tasklist()

[Oleg Nesterov <oleg@tv-sign.ru>]

Eric W. Biederman wrote:
>
> Oleg Nesterov <oleg@tv-sign.ru> writes:
>
> > handle_stop_signal() does not need tasklist_lock for
> > SIG_KERNEL_STOP_MASK signals anymore.
>
> Small question.
>
> If I read the code correctly the only thing handle_stop_signal needs
> the tasklist_lock for is to protect task->parent, for the
> do_notify_parent_cldstop(...) case.

Yes, exactly.

> If this is correct.  I think I see a path to kill read_lock(&tasklist_lock)
> completely.
>
> - Protect task->parent with the rcu_read_lock && task_lock().
> - Use the rcu forms of list_add/list_del on the tasklist.
> - replace read_lock(&tasklist_lock) with rcu_read_lock().
> - Make tasklist_lock a simple spin lock.
>
> Comments?

I must admit, I am not brave enough to even think about this
now :)

I already thought about protecting ->parent with task_lock(),
but I can't find a reasonable solution.

As for handle_stop_signal(), there is another problem.
do_notify_parent_cldstop takes ->parent's sighand->siglock, so
the caller drops child's. And this is possible only because we
are holding tasklist_lock.

Somehow we need to lock both the parent and the child, and what
if child does ptrace on it's ->real_parent?

Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/