[2.6 patch] drivers/block/nbd.c: don't defer compile error to runtime (fwd)

If we can detect a problem at compile time, the compilation should fail.


Signed-off-by: Adrian Bunk <[email protected]>

---

This patch was already sent on:
- 20 Feb 2006
- 3 Sep 2005

--- linux-2.6.13-mm1-full/drivers/block/nbd.c.old	2005-09-02 23:48:27.000000000 +0200
+++ linux-2.6.13-mm1-full/drivers/block/nbd.c	2005-09-03 01:08:04.000000000 +0200
@@ -643,10 +643,7 @@
 	int err = -ENOMEM;
 	int i;
 
-	if (sizeof(struct nbd_request) != 28) {
-		printk(KERN_CRIT "nbd: sizeof nbd_request needs to be 28 in order to work!\n" );
-		return -EIO;
-	}
+	BUILD_BUG_ON(sizeof(struct nbd_request) != 28);
 
 	if (nbds_max > MAX_NBD) {
 		printk(KERN_CRIT "nbd: cannot allocate more than %u nbds; %u requested.\n", MAX_NBD,

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [2.6 patch] drivers/block/nbd.c: don't defer compile error to runtime (fwd)
    • From: Jan Engelhardt <[email protected]>

• Prev by Date: [2.6 patch] make UNIX a bool
• Next by Date: Re: kernel BUG at fs/locks.c:1932!
• Previous by thread: [2.6 patch] make UNIX a bool
• Next by thread: Re: [2.6 patch] drivers/block/nbd.c: don't defer compile error to runtime (fwd)
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]