Re: [-mm patch] net/dccp/ipv4.c: make struct dccp_v4_prot static

On 2/25/06, Adrian Bunk <[email protected]> wrote:
> On Fri, Feb 24, 2006 at 03:10:02AM -0800, Andrew Morton wrote:
> >...
> > Changes since 2.6.16-rc4-mm1:
> >...
> >  git-net.patch
> >...
> >  git trees.
> >...
>
>
> There's no reason for struct dccp_v4_prot being global.
>
>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> --- linux-2.6.16-rc4-mm2-full/net/dccp/ipv4.c.old       2006-02-25 04:32:45.000000000 +0100
> +++ linux-2.6.16-rc4-mm2-full/net/dccp/ipv4.c   2006-02-25 04:32:53.000000000 +0100
> @@ -1022,7 +1022,7 @@
>         .twsk_obj_size  = sizeof(struct inet_timewait_sock),
>  };
>
> -struct proto dccp_v4_prot = {
> +static struct proto dccp_v4_prot = {
>         .name                   = "DCCP",
>         .owner                  = THIS_MODULE,
>         .close                  = dccp_close,

Heck, the last series of patches were exactly to separate ipv4/ipv6 in
DCCP more clearly, how could I forget the cherry on top (sticking this static
in front of dccp_v4_prot)?

Eagle eyes indeed.

Thanks.

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • 2.6.16-rc4-mm2
    • From: Andrew Morton <[email protected]>
  • [-mm patch] net/dccp/ipv4.c: make struct dccp_v4_prot static
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: "Ghost" devices in /sys/firmware/edd
• Next by Date: Re: [PATCH] Define wc_wmb, a write barrier for PCI write combining
• Previous by thread: [-mm patch] net/dccp/ipv4.c: make struct dccp_v4_prot static
• Next by thread: usbfs2 panic [Was: 2.6.16-rc4-mm2]
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]