[PATCH 03/23] proc: Remove useless BKL in proc_pid_readlink.

We already call everything except do_proc_readlink
outside of the BKL in proc_pid_followlink, and there
appears to be nothing in do_proc_readlink that needs
any special protection.

So remove this leftover from one of the BKL cleanup
efforts.

Signed-off-by: Eric W. Biederman <[email protected]>


---

 fs/proc/base.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

da9fe7b5227340bea1f4bd1e246af4a921ce765a
diff --git a/fs/proc/base.c b/fs/proc/base.c
index 4cbbd2d..24a3526 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -1120,7 +1120,6 @@ static int proc_pid_readlink(struct dent
 	struct dentry *de;
 	struct vfsmount *mnt = NULL;
 
-	lock_kernel();
 
 	if (current->fsuid != inode->i_uid && !capable(CAP_DAC_OVERRIDE))
 		goto out;
@@ -1136,7 +1135,6 @@ static int proc_pid_readlink(struct dent
 	dput(de);
 	mntput(mnt);
 out:
-	unlock_kernel();
 	return error;
 }
 
-- 
1.2.2.g709a

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH 04/23] proc: Remove unnecessary and misleading assignments from proc_pid_make_inode.
    • From: [email protected] (Eric W. Biederman)

• References:
  • [PATCH 00/23] proc cleanup.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 01/23] tref: Implement task references.
    • From: [email protected] (Eric W. Biederman)
  • [PATCH 02/23] proc: Fix the .. inode number on /proc/<pid>/fd
    • From: [email protected] (Eric W. Biederman)

• Prev by Date: [PATCH 02/23] proc: Fix the .. inode number on /proc/<pid>/fd
• Next by Date: [PATCH 04/23] proc: Remove unnecessary and misleading assignments from proc_pid_make_inode.
• Previous by thread: [PATCH 02/23] proc: Fix the .. inode number on /proc/<pid>/fd
• Next by thread: [PATCH 04/23] proc: Remove unnecessary and misleading assignments from proc_pid_make_inode.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]