Looks good and tests ok, with one issue: I still have a preference for returning -ENOTTY over 0/0/0 when dm doesn't know the geometry. That said, most programs will see the zero cylinder count and make a guess, so it probably doesn't matter. If you're happy with it, I say put it in. Thanks for the cleanup, by the way! --Darrick On Wed, 2006-02-22 at 22:32 +0000, Alasdair G Kergon wrote: > On Fri, Feb 17, 2006 at 04:59:58PM -0800, Darrick J. Wong wrote: > > Here's the third revision, with the geometry pushed into mapped_device > > as well as fixes for the problems that you pointed out wrt string > > passing, lack of warning messages, etc. Thanks for all the great feedback! > > Almost there now: how does the version below look? > Corresponding userspace changes are in device-mapper CVS. > > Alasdair
Attachment:
signature.asc
Description: This is a digitally signed message part
- Follow-Ups:
- Re: [dm-devel] Re: [PATCH] User-configurable HDIO_GETGEO for dm volumes
- From: Alasdair G Kergon <[email protected]>
- Re: [dm-devel] Re: [PATCH] User-configurable HDIO_GETGEO for dm volumes
- References:
- [PATCH] User-configurable HDIO_GETGEO for dm volumes
- From: "Darrick J. Wong" <[email protected]>
- Re: [PATCH] User-configurable HDIO_GETGEO for dm volumes
- From: Alasdair G Kergon <[email protected]>
- Re: [PATCH] User-configurable HDIO_GETGEO for dm volumes
- From: "Darrick J. Wong" <[email protected]>
- Re: [dm-devel] Re: [PATCH] User-configurable HDIO_GETGEO for dm volumes
- From: Alasdair G Kergon <[email protected]>
- [PATCH] User-configurable HDIO_GETGEO for dm volumes
- Prev by Date: Re: sys_mmap2 on different architectures
- Next by Date: Re: Altix SN2 2.6.16-rc1-mm5 build breakage (was: msi support)
- Previous by thread: Re: [dm-devel] Re: [PATCH] User-configurable HDIO_GETGEO for dm volumes
- Next by thread: Re: [dm-devel] Re: [PATCH] User-configurable HDIO_GETGEO for dm volumes
- Index(es):
 |