Re: [patch 5/6] lightweight robust futexes: i386

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



In-Reply-To: <[email protected]>

On Tue, 21 Feb 2006 at 08:38:04 -0800, Ulrich Drepper wrote:
> On 2/21/06, Chuck Ebbert <[email protected]> wrote:
> > > +             : "=a" (oldval), "=m" (*uaddr)
> >                                  ^^^^
> >    Should be "+m" because it's both read and written.
> 
> No, this is why there is the "0" input parameter.

 But this is arg 1, not 0. With a memory clobber it's irrelevant
anyway though.

> > > +             : "memory"
> >                   ^^^^^^^^
> >    Is this necessary? Every possible memory location that could be
> > affected has been listed in the operands if the above change is made.
>
> This makes the asm a barrier for the compiler.

 A comment to that effect would be nice; IOW document the reason for it.

-- 
Chuck
"Equations are the Devil's sentences."  --Stephen Colbert

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux