Re: [PATCH] trivial: unneeded zero adding to per_cpu_pages->count

On 2/21/06, nkml00 <[email protected]> wrote:
> Unneeded addition (of zero). Compiler could optimize this, but "looks" illogical
>

Sorry, patch was not in patch -p1 format.

--- l1/mm/page_alloc.c-orig	2006-02-21 12:03:52.000000000 -0800
+++ l2/mm/page_alloc.c	2006-02-21 12:49:45.000000000 -0800
@@ -774,7 +774,7 @@ again:
 		pcp = &zone_pcp(zone, cpu)->pcp[cold];
 		local_irq_save(flags);
 		if (!pcp->count) {
-			pcp->count += rmqueue_bulk(zone, 0,
+			pcp->count = rmqueue_bulk(zone, 0,
 						pcp->batch, &pcp->list);
 			if (unlikely(!pcp->count))
 				goto failed;

Signed-off-by: nkml00 <[email protected]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] trivial: unneeded zero adding to per_cpu_pages->count
    • From: nkml00 <[email protected]>

• Prev by Date: Re: CD writing in future Linux (stirring up a hornets' nest)
• Next by Date: Re: [2.6 patch] unexport install_page
• Previous by thread: [PATCH] trivial: unneeded zero adding to per_cpu_pages->count
• Next by thread: [patch] i386: let signal handlers set the resume flag
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]