Re: Oops in Kernel 2.6.16-rc4 on Modprobe of saa7134.ko

[Alexey Dobriyan <adobriyan@gmail.com>]

On Mon, Feb 20, 2006 at 01:04:24PM +0000, Brian Marete wrote:
> Modprobe(8)ing saa7134.ko causes an oops. This
> is repeatable and happens every time I try to load saa7134.ko. My
> saa7134 compatible TV card is not known by the driver, but TV has worked
> in pervious kernel versions with the insmod option `card=3'. The FM
> radio has never worked.:) I use the following insmod options for
> saa7134.ko:
>
> `options saa7134 card=3 disable_ir=1'
			  ^^^^^^^^^^^^

This prevents saa7134_input_init1() from initializing ->remote which is
needed by

   657	static int saa7134_hwinit2(struct saa7134_dev *dev)
   658	{
   659		unsigned int irq2_mask;
   660		dprintk("hwinit2\n");
   661
   662		saa7134_video_init2(dev);
   663		saa7134_tvaudio_init2(dev);
   664
   665		/* enable IRQ's */
   666		irq2_mask =
   667			SAA7134_IRQ2_INTE_DEC3    |
   668			SAA7134_IRQ2_INTE_DEC2    |
   669			SAA7134_IRQ2_INTE_DEC1    |
   670			SAA7134_IRQ2_INTE_DEC0    |
   671			SAA7134_IRQ2_INTE_PE      |
   672			SAA7134_IRQ2_INTE_AR;
   673
   674		if (dev->has_remote == SAA7134_REMOTE_GPIO) {
   675	===>		if (dev->remote->mask_keydown & 0x10000)	<===
   676				irq2_mask |= SAA7134_IRQ2_INTE_GPIO16;
   677			else if (dev->remote->mask_keydown & 0x40000)
   678				irq2_mask |= SAA7134_IRQ2_INTE_GPIO18;
   679			else if (dev->remote->mask_keyup & 0x40000)
   680				irq2_mask |= SAA7134_IRQ2_INTE_GPIO18A;
   681		}


Brian, please, try without this module parameter.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/