Hi,
> What is ehca_show_flightrecorder() trying to do that snprintf() is
> not fast enough? If you need to pass a binary structure back to
> userspace (with a kernel address in it??) then sysfs is not the right
> place to put it. Look at debugfs; or relayfs might make the most
> sense for your flightrecorder stuff.
I agree debugfs or relayfs would be better suited. Of course as the
driver matures this form of debug is probably not required at all.
> +#include "hcp_sense.h" /* TODO: later via hipz_* header file */
> +#include "hcp_if.h" /* TODO: later via hipz_* header file */
I count 88 TODOs in the driver, it would be nice to get rid of some of
them like the two above, so we can concentrate on the important TODOs :)
> +#if LINUX_VERSION_CODE >= KERNEL_VERSION(2,6,12)
> +#define EHCA_RESOURCE_ATTR_H(name) \
> +static ssize_t ehca_show_##name(struct device *dev, \
> + struct device_attribute *attr, \
> + char *buf)
> +#else
> +#define EHCA_RESOURCE_ATTR_H(name) \
> +static ssize_t ehca_show_##name(struct device *dev, \
> + char *buf)
> +#endif
No need for kernel version ifdefs.
Anton
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
