Re: [PATCH 1/1] ACPI: Atlas ACPI driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Mon, Feb 20, 2006 at 10:13:53AM +0800, [email protected] wrote:

> +	/* setup proc entry to set and get lcd brightness */
> +	proc = create_proc_read_entry("lcd", S_IFREG | S_IRUGO | S_IWUSR,
> +			atlas_proc_dir, atlas_read_proc_lcd, atlas_dev);

For basic sanity, could this please be a standard backlight driver 
rather than sticking yet another backlight control under yet another 
directory in /proc? It makes userspace much, much easier. 
drivers/video/backlight/corgi_bl.c is an example, but also see my posts 
to acpi-devel with patches that add it to existing acpi drivers.

> +		return atlas_acpi_button_add(device);

What buttons does the hardware have? Would it make more sense for it to 
be an input driver rather than (or as well as) just dropping stuff in 

Matthew Garrett | [email protected]
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at
Please read the FAQ at

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux