Re: Flames over -- Re: Which is simpler?

[Pavel Machek <pavel@suse.cz>]

On Ne 19-02-06 00:52:45, Phillip Susi wrote:
> Pavel Machek wrote:
> >>Provided that you sync before suspending, and there are no open files on 
> >>the filesystem, then yes, no data will be lost.  If there are open files 
> >>on the fs, such as a half saved document, or a running binary, or say, 
> >>the whole root fs, then you're going to loose data and even panic the 
> >>kernel, sync or no sync.  From the user perspective, this is
> >>unacceptable.
> >
> >While with your solution, you do not loose one open file, you loose
> >whole filesystem. Which is unacceptable.
> 
> Only if the user is foolish enough to modify the media somehow while the 
> system is suspended and replace it, which is exactly how non USB disks 
> currently behave.

"Foolish enough"? Multiple users told you that they consider that use
case okay for hotpluggable drives.

> >>connection to the drive thy are using is USB?  Every other type of drive 
> >>and interface does not suffer from this problem.
> >
> >Because it is okay to unplug usb disk on runtime, while it is not okay
> >to unplug ATA disk on runtime. And because alternatives suck even more.
> >
> 
> Actually, no, it is not okay to unplug a usb disk at runtime while it is 
> mounted.  It never has been and it never will be.  Also we aren't 

Ever heard about "journalling"?

> talking about runtime, we're talking about while the system is 
> suspended, when there is no way for the kernel to know whether or
> not 

If it is okay during runtime, it should be okay while suspended. Don't
expect users to know about power on USB buses. You may call any system
that does not support standby power on USB broken if you wish... 

> the device was unplugged, since it _allways_ appears to have been 
> unplugged.  The alternative in the uncommon case ( where the user 
> modifies the media while suspended ) does not suck any worse than it 
> currently does on non usb media, and the common case ( where the user 
> doesn't ) sucks worse currently with usb than others.

"Does not such any worse than non-usb" does not cut it here. USB disks
are too easy to unplug/replug.

Anyway, your mail came without a patch, again. That's useless; if you
implement layer above floppies/usb sticks that can recognize same
disk, maybe we can talk about that.
								Pavel
-- 
Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/