Re: [PATCH] Keys: Deal properly with strnlen_user()

Andrew Morton <[email protected]> wrote:

> ug.  Well it's your code ;)

Yeah...

> It should really parameterise `ret' too.
> 
> Are you sure you want to do this?  From my reading, doing it with plain old
> subroutines would work?

That complicates the error handling and potentially produces less optimal
code:-/

I think bringing it together though is definitely the right thing to do: fewer
bits to fix and all that.

Davud
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH] Keys: Deal properly with strnlen_user()
    • From: Andrew Morton <[email protected]>
  • [PATCH] Keys: Deal properly with strnlen_user()
    • From: David Howells <[email protected]>

• Prev by Date: Re: Flames over -- Re: Which is simpler?
• Next by Date: Re: CD writing in future Linux (stirring up a hornets' nest)
• Previous by thread: Re: [PATCH] Keys: Deal properly with strnlen_user()
• Next by thread: [PATCH] add __force tag to fb_readb, etc.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]