Re: [PATCH] add asm-generic/mman.h

[Badari Pulavarty <pbadari@us.ibm.com>]

On Wed, 2006-02-15 at 18:50 +0200, Michael S. Tsirkin wrote:
> Quoting r. Badari Pulavarty <pbadari@us.ibm.com>:
> > Subject: Re: [PATCH] add asm-generic/mman.h
> > 
> > On Wed, 2006-02-15 at 17:16 +0200, Michael S. Tsirkin wrote:
> > > How does the following look (against gc3-git)?
> > 
> > I tried to do the same earlier (while doing MADV_REMOVE) and got
> > ugly (I was trying to completely get rid of asm-specific ones), 
> > so I gave up.
> > 
> > Anyway,
> > 
> > 
> > > Index: linux-2.6.16-rc3/include/asm-generic/mman.h
> > > ===================================================================
> > > --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> > > +++ linux-2.6.16-rc3/include/asm-generic/mman.h	2006-02-15 19:59:41.000000000 +0200
> > ..
> > > +#define MS_ASYNC	1		/* sync memory asynchronously */
> > > +#define MS_SYNC		2		/* synchronous memory sync */
> > > +#define MS_INVALIDATE	4		/* invalidate the caches */
> > 
> > Shouldn't this be ?
> > 
> > +#define MS_ASYNC	1		/* sync memory asynchronously */
> > +#define MS_INVALIDATE	2		/* invalidate the caches */
> > +#define MS_SYNC	4		/* synchronous memory sync */
> > 
> > Thanks,
> > Badari
> > 
> 
> Note that this only looks misaligned in the patch. When you apply, +
> disappears and numbers get aligned.
> Other stuff in asm-xx/mman.h is aligned by tabs and not by spaces,
> so why should these options be aligned by spaces?


I am not talking about alignment or spaces. 
What I meant was ..

MS_SYNC should be 4
MS_INVALIDATE should be 2

You got it other way in your patch.

Thanks,
Badari

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/